KarpelesLab / libwallet / 25849751291

24%

Build Type

push

github

Committed by MagicalTux

Commit Message

wltswap: Swap:quotes — per-provider attempts, no silent fallback

The runQuote layer was silently falling back from Jupiter to dFlow on
ErrCodeProviderUnavailable. Hosts only ever saw one provider's result,
and there was no way for the user to compare. Worse, the fallback
didn't fire for Jupiter's HTTP 400 "Failed to get quotes" (the most
common no-route signature on small Solana swaps) — that got
classified as ErrCodeProviderBadRequest, which the fallback skipped.

Replaced with explicit comparison:

  Swap:quotes (plural) fans the request out to every provider
  available for the chain in parallel and returns one QuoteAttempt
  per provider. Successful attempts carry a Quote with its own
  cached quoteId; failed attempts carry a typed SwapError. The host
  renders the attempts side-by-side and the user picks. libwallet
  never silently switches providers.

  Swap:quote (singular) no longer silently falls back. Primary
  provider's result — error or quote — is what the caller gets.

  Jupiter HTTP 400 "Failed to get quotes" reclassified from
  ErrCodeProviderBadRequest to ErrCodeNoLiquidity to match the
  HTTP 200 empty-transaction path that already maps to no_liquidity.
  Hosts that branch on the code now see one code for both no-route
  surfaces regardless of how Jupiter chose to report it.

Dart side: SwapApi.quotes() + QuoteAttempt + SwapError model. The
silent-fallback removal in Swap:quote is documented in the doc
comment plus the CHANGELOG.

Tests cover: runQuotes collects per-provider attempts (one
successful + one with NoLiquidity), provider order is preserved,
each successful attempt gets a QuoteId stamped so execute works
immediately, ProviderLabel maps correctly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

51 of 118 new or added lines in 4 files covered. (43.22%)

1 existing line in 1 file now uncovered.

3551 of 16447 relevant lines covered (21.59%)

114.27 hits per line