raystack / frontier / 25849580212

42%

main: 42%

Build Type

Pull #1611

github

Committed by whoAbhishekSah

Commit Message

refactor(group): migrate RemoveGroupUser handler to membership

The RemoveGroupUser RPC handler now delegates to a new
membershipService.RemoveGroupMember, completing the symmetry with the
AddGroupUsers migration (#1608). The proto RPC is unchanged.

- Adds RemoveGroupMember to core/membership/service.go. Validates
  principal, enforces the min-owner constraint via the existing atomic
  DeleteWithMinRoleGuard, cleans up both group#owner and group#member
  relations, and emits an audit event.
- Moves the min-owner pre-check out of the handler. Previously the
  handler called userService.ListByGroup(group.AdminRole) and compared
  counts; that race-prone two-step is replaced by validateMinGroupOwner
  + the atomic guard pattern already used by SetGroupMemberRole.
- Adds the GroupMemberRemovedEvent audit constant.

groupService.RemoveUsers / removeUsers are intentionally kept — they
serve the user-cascade path (core/deleter and group.Delete), which must
bypass the min-owner constraint when the user is being destroyed
system-wide. Matches the org pattern where Service.RemoveUsers and
RemoveOrganizationMember coexist.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #1611: refactor(group): migrate RemoveGroupUser handler to membership

Coverage Stats

73 of 88 new or added lines in 2 files covered. (82.95%)

4 existing lines in 1 file now uncovered.

15950 of 37651 relevant lines covered (42.36%)

11.89 hits per line