KarpelesLab / libwallet / 25844804998

24%

Build Type

push

github

Committed by MagicalTux

Commit Message

wltnet: Network.AddressUrl + ResolvedBlockExplorer field

Adds the address-URL helper requested for "tap address → open in
explorer" affordances on signing-critical rows (verifying-contract,
ERC-20 effect rows, watch_asset, SIWE, bitcoin IOs). Mirrors
TransactionUrl that 0.4.26 fixed for the cluster-suffix issue —
identical nullability semantics, identical per-chain branching,
identical "" return when no explorer can be resolved.

Refactor pulls the resolved-base computation out of TransactionUrl
into a shared helper (ResolvedBlockExplorer) so AddressUrl reuses it,
and pulls the Solana cluster suffix out into solanaClusterSuffix() so
both helpers share the "?cluster=devnet" logic. TransactionUrl wire
output is unchanged — covered by the existing TestNetworkTransactionUrl
table.

Network.MarshalJSON now embeds ResolvedBlockExplorer so the Dart side
can compose URLs locally without an FFI round trip per render.

Dart Network model gains:
- resolvedBlockExplorer field (read from JSON)
- transactionUrl(hash) and addressUrl(addr) sync helpers that produce
  the same URLs as the Go side using the embedded resolved base
- per-chain branching matches Go (Solana mainnet/mainnet-beta bare,
  devnet/testnet append ?cluster=<id>; "" when no resolved explorer)

Custom networks with no BlockExplorer configured return "" — host
hides the affordance, doesn't guess at the path shape. Matches the
spec's "Custom networks: return empty string" requirement verbatim.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

38 of 41 new or added lines in 1 file covered. (92.68%)

290 existing lines in 4 files now uncovered.

3412 of 16228 relevant lines covered (21.03%)

117.93 hits per line