• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

dcdpr / jp / 25827631389
65%

Build:
DEFAULT BRANCH: main
Ran 13 May 2026 09:37PM UTC
Jobs 1
Files 302
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

13 May 2026 09:31PM UTC coverage: 66.696% (+0.2%) from 66.49%
25827631389

push

github

web-flow
fix(attachment_internal, cli): Skip missing conversations on query (#635)

Previously, if a `jp://` attachment referenced a conversation that had
been archived or removed, `jp query` would hard-fail with an error,
making the conversation unusable until the stale attachment was manually
cleaned up.

This change introduces a dedicated `ResolveError` enum in
`jp_attachment_internal`, replacing the opaque `Box<dyn Error>` return
type on `resolve()`. The new `ConversationMissing` variant is surfaced
separately from all other failures (`Other`), giving callers a
structured way to distinguish "conversation is gone" from real errors.

On the CLI side, a new `load_conversation_attachments` helper in
`jp_cli` uses this distinction: when a `jp://` attachment resolves to
`ConversationMissing`, it logs a warning and skips the reference instead
of aborting the query. Any other failure (invalid URI, I/O error, etc.)
is still treated as a hard error. The `query` command now calls this
helper instead of resolving attachments directly via
`register_attachment`.

A corresponding `AttachmentConversationMissing` error variant is added
to the CLI error type so the missing-conversation case can be matched
exhaustively throughout the call stack.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

32 of 51 new or added lines in 4 files covered. (62.75%)

92 existing lines in 4 files now uncovered.

26135 of 39185 relevant lines covered (66.7%)

206.41 hits per line

Uncovered Changes

Lines Coverage ∆ File
8
74.02
-2.15% crates/jp_attachment_internal/src/lib.rs
6
20.17
-0.27% crates/jp_cli/src/cmd.rs
3
52.87
0.52% crates/jp_cli/src/cmd/query.rs
2
44.87
44.87% crates/jp_cli/src/cmd/attachment.rs

Coverage Regressions

Lines Coverage ∆ File
53
68.15
0.24% crates/jp_attachment_github/src/lib.rs
22
18.75
18.75% crates/jp_cli/src/cmd/conversation/rm.rs
16
33.78
33.78% crates/jp_cli/src/cmd/conversation/archive.rs
1
44.87
44.87% crates/jp_cli/src/cmd/attachment.rs
Jobs
ID Job ID Ran Files Coverage
1 25827631389.1 13 May 2026 09:37PM UTC 302
66.7
GitHub Action Run
Source Files on build 25827631389
  • Tree
  • List 302
  • Changed 10
  • Source Changed 8
  • Coverage Changed 10
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #25827631389
  • 4d69ecb5 on github
  • Prev Build on main (#25800698068)
  • Next Build on main (#25887922763)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc