dcdpr / jp / 25827631389

65%

Build Type

push

github

Committed by web-flow

Commit Message

fix(attachment_internal, cli): Skip missing conversations on query (#635)

Previously, if a `jp://` attachment referenced a conversation that had
been archived or removed, `jp query` would hard-fail with an error,
making the conversation unusable until the stale attachment was manually
cleaned up.

This change introduces a dedicated `ResolveError` enum in
`jp_attachment_internal`, replacing the opaque `Box<dyn Error>` return
type on `resolve()`. The new `ConversationMissing` variant is surfaced
separately from all other failures (`Other`), giving callers a
structured way to distinguish "conversation is gone" from real errors.

On the CLI side, a new `load_conversation_attachments` helper in
`jp_cli` uses this distinction: when a `jp://` attachment resolves to
`ConversationMissing`, it logs a warning and skips the reference instead
of aborting the query. Any other failure (invalid URI, I/O error, etc.)
is still treated as a hard error. The `query` command now calls this
helper instead of resolving attachments directly via
`register_attachment`.

A corresponding `AttachmentConversationMissing` error variant is added
to the CLI error type so the missing-conversation case can be matched
exhaustively throughout the call stack.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

32 of 51 new or added lines in 4 files covered. (62.75%)

92 existing lines in 4 files now uncovered.

26135 of 39185 relevant lines covered (66.7%)

206.41 hits per line