KarpelesLab / goro / 25827715594

13%

push

github

vm: allocate fresh ZVal wrapper on local assignment (bug26639)

storeLocal previously stored the source ZVal pointer directly. When
the source came from another slot (\$b = \$a), both slots ended up
sharing the same *ZVal. A subsequent by-ref builtin that mutates
through one (e.g. mb_convert_variables on \$b) calls ZVal.Set, which
overwrites the shared wrapper's v field — \$a sees the change too,
contradicting PHP's value-copy semantics for scalars.

Allocate a fresh ZVal wrapper around the same underlying Val for
non-ref, non-array source values. The Val itself (ZString, ZInt, …)
is shared without copying because it's immutable; only the wrapper
needs to be independent so per-slot Set calls don't propagate.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

9 of 9 new or added lines in 1 file covered. (100.0%)

14047 of 115903 relevant lines covered (12.12%)

2456.51 hits per line