kivy / kivy / 25823201857

60%

Build Type

push

github

Committed by web-flow

Commit Message

Tests: replace httpbin with local pytest-httpserver for UrlRequest (#9304)

* Tests: replace httpbin with local pytest-httpserver for UrlRequest

The urllib UrlRequest tests have been intermittently flaky because they
depended on the public httpbin.org service and on polling
UrlRequest.is_finished, which can race the Clock-dispatched terminal
callback and leave the last queued event as 'progress'.

Run everything in-process against a pytest-httpserver instance:

  - Default httpserver fixture covers HTTP routes (GET payload sized
    above chunk_size to drive on_progress, and a basic-auth route).
  - New httpsserver fixture spins up a second HTTPServer with a
    trustme-backed CA so the test_ca_file https case validates a real
    cert via UrlRequest's ca_file= parameter.
  - New wait_for_terminal_event helper waits on the test callback
    queue's last event being success/redirect/error/failure rather
    than on is_finished, which removes the race entirely.
  - Drop the nonetwork / errno 11001 skip dances; tests no longer
    touch the public internet.
  - Add a 30s pytest-timeout per test so a wedged worker thread
    cannot hang CI.

Adds pytest-httpserver and trustme to the dev extras in setup.cfg.

* Tests: bypass slow loopback rDNS in UrlRequest httpserver fixtures

werkzeug's BaseWSGIServer (which backs pytest-httpserver) calls
socket.getfqdn(host) after binding to populate server_name. On the
macOS GitHub runner the reverse-DNS lookup for 127.0.0.1 hangs for
tens of seconds, so server.start() never returns and the test trips
pytest-timeout before doing anything useful:

  >  hostname, aliases, ipaddrs = gethostbyaddr(name)
  E  Failed: Timeout (>30.0s) from pytest-timeout.

Add two fixtures to kivy/tests/test_urlrequest/conftest.py:

* httpserver_listen_address override -> ("localhost", 0), so
  pytest-httpserver binds to localhost explicitly rather than
  whatever its default is in the installed version.
* _fast_loopback_getfqdn (session-sc... (continued)

Coverage Stats

3236 of 6453 branches covered (50.15%)

219 of 222 new or added lines in 2 files covered. (98.65%)

9 existing lines in 1 file now uncovered.

28514 of 47976 relevant lines covered (59.43%)

1.17 hits per line