pomerium / pomerium / 25821135931

52%

Build Type

push

github

Committed by web-flow

Commit Message

core/config: fix generated bool setter (#6344)

## Summary
Fix a bug in the generated protobuf/go config conversion code.

## Details
When working with a protobuf type with a non-nullable bool:

```proto
message OutlierDetection {
  bool split_external_local_origin_errors = 12;
}
```

The `ToProto` conversion would use the `setNullableBoolToProto`
function:

```go
setNullableBoolToProto(new(&obj.SplitExternalLocalOriginErrors), src.SplitExternalLocalOriginErrors)
```

Because we were using `new` the value would then immediately be
discarded and the actual boolean never set. So instead we will now call
the non-nullable `setBoolToProto` which will set the value properly, and
that method was updated to take a `nullable.Value` instead of a pointer:

```go
func setBoolToProto(dst *bool, src Value[bool]) error {
	if !src.IsSet {
		return nil
	}
	*dst = src.Value
	return nil
}
```

## Related issues

## AI disclosure

none
## Checklist

- [ ] reference any related issues
- [ ] updated unit tests
- [ ] add appropriate label (`enhancement`, `bug`, `breaking`,
`dependencies`, `ci`)
- [x] disclosed AI usage (or wrote "none") per AI_POLICY.md
- [x] ready for review

Coverage Stats

0 of 11 new or added lines in 2 files covered. (0.0%)

30 existing lines in 7 files now uncovered.

36334 of 79239 relevant lines covered (45.85%)

307.45 hits per line