kubevirt / hyperconverged-cluster-operator / 25817252178
80%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 143
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.481% (+0.03%) from 80.454%
25817252178

push

github

web-flow 
Use v1 in the hyperconverged controller (#4237)

* use v1 in the HcoRequest type

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* create HyperConverged v1 for unit-tests

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* move the operands package to v1

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* move the goldenimages package to v1 API

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* move controlles/handlers package to v1 API

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* move the aie package to v1 API

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* move the wasp-agent package to v1 API

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* move the operandhandler package to v1 API

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* move the hyperconverged package to v1 API

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* move the monitoring/hyperconverged/controllers package to v1 API

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Move validation logic to v1

The core validation was based on v1beta1 API version. This is now must
be fixed, to follow the changes in the handlers package functions, that
are also used in the validation webhook logic.

This PR moved the core validation logic to the v1 validator, and also
did some refactoring, to get more maintainable code.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* node controller tests: restore NewHco

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* remove the e2e test for high-burst tuning policy, as it's not supported anymore

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

---------

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

517 of 535 new or added lines in 45 files covered. (96.64%)

9 existing lines in 5 files now uncovered.

10436 of 12967 relevant lines covered (80.48%)

2.06 hits per line

Uncovered Changes

Lines Coverage ∆ File
7
81.4
 0.0% controllers/handlers/wasp-agent/daemonset.go
6
78.66
 -0.25% controllers/hyperconverged/hyperconverged_controller.go
1
57.02
 0.0% controllers/handlers/aie/webhook_config.go
1
97.16
 0.05% controllers/handlers/kubevirt.go
1
95.1
 0.0% controllers/handlers/networkAddons.go
1
71.7
 0.0% controllers/operands/conditionalHandler.go
1
93.02
 -2.07% pkg/webhooks/validator/v1beta1_validator.go

Coverage Regressions

Lines Coverage ∆ File
3
81.4
 0.0% controllers/handlers/wasp-agent/daemonset.go
3
93.02
 -2.07% pkg/webhooks/validator/v1beta1_validator.go
1
97.16
 0.05% controllers/handlers/kubevirt.go
1
95.1
 0.0% controllers/handlers/networkAddons.go
1
78.66
 -0.25% controllers/hyperconverged/hyperconverged_controller.go
Jobs
ID Job ID Ran Files Coverage
1 Unit - 25817252178.1 143
80.48
 GitHub Action Run
Source Files on build 25817252178