sclgo / impala-go / 25812925495

84%

Build Type

push

github

Committed by web-flow

Commit Message

feat: extend connection validation to TLS connections (#106)

This change moves dialing from Thrift into the driver for TLS
connections. This allows us to inject a workaround for the Thrift bug
which breaks connection validation on TLS connections. The new dialing
code also supports context, so context is respected in Connector.Connect
but only in case of TLS.

The PR also exposes two new sentinel errors sentinel errors
(ErrOpenFailed and ErrBadDSN).

CI testing is extended to windows because the library started using unix
only behavior - connection check - in #98 .

Closes #105

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Coverage Stats

81 of 85 new or added lines in 3 files covered. (95.29%)

7 existing lines in 2 files now uncovered.

1090 of 1291 relevant lines covered (84.43%)

208.2 hits per line