FlexMeasures / flexmeasures / 25805606749

80%

Build Type

push

github

Committed by web-flow

Commit Message

Fix auth issues: child asset creation, account page access (#2163)

* fix: auth issues for child asset creation, account page access, and breadcrumb test

Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/bbb22573-9b83-4d71-ac1b-f8b9de70f61b

Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

* fix: add null checks and changelog entry for auth fixes

Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/bbb22573-9b83-4d71-ac1b-f8b9de70f61b

Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

* fix: update changelog with correct PR number #2163

Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/bbb22573-9b83-4d71-ac1b-f8b9de70f61b

Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

* fix: address review comments - docstrings, changelog, None account check

Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/e5059bde-7621-45d1-a6db-bb2f0025c04d

Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

* agents/test-specialist: enforce docstring hygiene for tests (PR #2163 review)

Context:
- PR #2163 reviewer (@Flix6x) requested three specific docstring improvements
- Test docstrings contained 'Bug (on main)' / 'Fix:' / 'Expected: X on main, Y with fix'
  paragraphs describing pre-fix behaviour, which belong in commit messages not source code
- Sentences were hard-wrapped mid-phrase to fit ~79 chars, making docstrings harder to read
- Double spaces after punctuation appeared in docstrings despite the rule existing in AGENTS.md

Change:
- Added 'Docstring Style Rules' section with three enforced sub-rules:
  1. No historical context ('on main', 'before/after fix') in test docstrings
  2. Keep sentences on as few lines as possible; avoid mid-sentence line breaks
  3. No double spaces after punctuation (mirrors AGENTS.md rule, now explicit in this agent)

Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

* fix:... (continued)

Coverage Stats

18 of 20 new or added lines in 2 files covered. (90.0%)

4 existing lines in 2 files now uncovered.

12551 of 15630 relevant lines covered (80.3%)

0.8 hits per line