kubernetes-sigs / kubebuilder / 25791217132

82%

push

github

🐛 (grafana/v1alpha): Fix file handle leak on config read error (#5682)

* fix(grafana/v1alpha): close file handle on config read error

Replace the manual close pattern with idiomatic defer f.Close()
immediately after the successful open. The original code only closed
the file on the success path; if configReader returned an error, the
file descriptor leaked.

Since this is a read-only file (os.Open), close errors are not
actionable.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>

* Address review: check close error on both paths instead of nolint

Remove defer f.Close() with nolint:errcheck directive. Instead, check
the close error explicitly on both the error and success paths, which
satisfies errcheck without suppressing the lint rule.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>

---------

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>

0 of 3 new or added lines in 1 file covered. (0.0%)

7716 of 9376 relevant lines covered (82.3%)

73.57 hits per line