supabase / cli / 25790264378
64%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 219
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 63.734% (-0.007%) from 63.741%
25790264378

push

github

web-flow 
chore(cli/telemetry): clean up audited events (#5234)

## Summary
CLI telemetry audit cleanup from GROWTH-797. Removes one over-firing
`cli_upgrade_suggested` site, aligns the `cli_stack_started` capture
pattern with the rest of the codebase, and documents an early-return
invariant on `TrackUpgradeSuggested` so future audits don't misread the
SSO update flow as a double-fire.

## Changes
- `cli_upgrade_suggested` no longer fires on the read-only
`vanity-subdomains check` command (kept on `activate`, the actual gated
action). User still sees the billing-URL hint.
- `cli_stack_started` capture simplified to `_ =
phtelemetry.FromContext(ctx).Capture(...)`, matching `cmd/root.go`.
`Service.canSend()` already handles nil receivers.
- Comment on `internal/sso/update/update.go` PUT branch + docstring on
`TrackUpgradeSuggested` explaining that GET-fail and PUT-fail are
mutually exclusive via early-return, so at most one event fires per
command invocation. Deleting one site without the other undercounts
gated users.

## Testing
Tested locally in `apps/cli-go`:
- [x] `go test ./internal/login/... ./internal/telemetry/...
./internal/start/... ./internal/sso/... ./internal/vanity_subdomains/...
-count=1` — all pass.
- [x] `cli_stack_started` group/event assertion at
`internal/start/start_test.go:248-253` still passes after the nil-guard
removal.
- [x] `go vet ./...` and `go build ./...` clean.

Post-merge verification on PostHog:
- `cli_upgrade_suggested` volume on `feature_key = 'vanity_subdomain'`
should drop (was firing on both `check` and `activate`; now only
`activate`).

## Linear
- fixes GROWTH-797

---------

Co-authored-by: Andrew Valleteau <avallete@users.noreply.github.com>

9991 of 15676 relevant lines covered (63.73%)

7.06 hits per line

Coverage Regressions

Lines Coverage ∆ File
8
64.66
 0.08% internal/start/start.go
3
66.09
 -2.61% internal/debug/postgres.go
2
51.19
 -0.62% internal/sso/update/update.go
2
80.61
 0.0% internal/storage/rm/rm.go
Jobs
ID Job ID Ran Files Coverage
1 25790264378.1 219
63.73
 GitHub Action Run
Source Files on build 25790264378