ingitdb / ingitdb-cli / 25789578953

96%

Build Type

push

github

Committed by inGitDB Dev

Commit Message

feat(cli)!: wire --remote everywhere, remove --github flag

Rename addGitHubFlags → addRemoteFlags and register --remote, --token,
and --provider on every verb that previously accepted --github (insert,
update, delete, select, list collections, plus the record-CRUD
commands). The --github flag is removed cleanly — no shim. Anyone
running it gets cobra's standard "unknown flag" error.

Internals:
  - parseGitHubRepoSpec and githubRepoSpec are deleted; the canonical
    parsed form is remoteSpec from remote_helpers.go.
  - newGitHubConfig now takes a remoteSpec (using Owner()/Repo()).
  - readRemoteDefinitionForID / ForCollection take a remoteSpec.
  - resolveRemoteFromFlags (in cobra_helpers.go) is the new shared
    entry point: parse the value, validate the provider override, and
    return the canonical spec. Errors fire before any I/O.
  - remoteToken(cmd, host) replaces githubToken(cmd) and consults
    --token / <HOST_NO_TLD>_TOKEN / <HOST_FULL>_TOKEN in that order,
    so GITHUB_TOKEN continues to work for github.com via the
    mechanical rule.

Renames at the package level:
  - resolveGitHubRecordContext  → resolveRemoteRecordContext
  - resolveInsertContextGitHub  → resolveInsertContextRemote
  - listCollectionsGitHub       → listCollectionsRemote
                                 + listCollectionsRemoteWithSpec
                                   (testable inner form)

Test updates:
  - TestParseGitHubRepoSpec_* deleted; the canonical parser tests
    live in remote_helpers_test.go as TestParseRemoteSpec_*.
  - TestListCollectionsGitHub_* renamed to TestListCollectionsRemote_*
    and now call listCollectionsRemoteWithSpec with sampleRemoteSpec().
  - Flag-name arrays in delete/insert/update/select tests use
    "remote" in place of "github".
  - --github=owner/repo in invocations becomes
    --remote=github.com/owner/repo.

Verified: go build ./..., go test ./... (all pass), golangci-lint
(0 issues). The only remaining mentions of "github" in... (continued)

Coverage Stats

46 of 69 new or added lines in 10 files covered. (66.67%)

5 existing lines in 3 files now uncovered.

7323 of 9082 relevant lines covered (80.63%)

0.95 hits per line