ingitdb / ingitdb-cli / 25784834508

96%

Build Type

push

github

Committed by inGitDB Dev

Commit Message

fix(cli/drop): detect ambiguous view names across collections

Resolves the duplicate-view-name ambiguity flagged in the cli/drop
final code review. Previously, `drop view <name>` returned after the
first collection match — if two collections both contained a view with
the same name, only one was dropped silently and the other was left
intact (a non-deterministic surprise).

The new behavior scans ALL collections, collects every match, and:
- 0 matches: error (or silent success with --if-exists)
- 1 match: drop it (unchanged from before)
- 2+ matches: error naming every conflicting parent collection,
  recommending --in=<collection> to disambiguate. NO view is dropped —
  preserving atomicity under ambiguous input.

Adds a new --in=<collection> flag on `drop view` that scopes the
search to a single collection's $views directory. Unknown collection
names supplied via --in are rejected with a clear diagnostic.

Refactors the view-removal logic out of the RunE into a small
removeViewFiles(viewPath, colDir) helper for clarity.

Three new tests cover the ambiguity error path, the --in
disambiguation happy path, and the --in unknown-collection error.

Spec: cli/drop#req:drop-view-removes-schema-and-materialized-files
(no spec change required — this is a correctness fix the existing REQ
implicitly demands)

Coverage Stats

49 of 57 new or added lines in 1 file covered. (85.96%)

1 existing line in 1 file now uncovered.

7211 of 8959 relevant lines covered (80.49%)

0.95 hits per line