KarpelesLab / goro / 25772374705

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: by-ref user-function calls run VM body; ref propagation via hashtable

The compiler used to skip VM-compile entirely for any function with
by-ref parameters or by-ref \`use\` captures. Now those bodies VM-
compile too; the AST callBody binds refs into the FuncContext
hashtable before vm.Run starts, and writes through the ref propagate
via ctx.OffsetSet during OpStoreLocal / OpOpAssignLocal.

Three pieces wire this together:

* TryBuildVMClosureBody now takes \`hasByRef\` so the emitter can
  force SlotOnly=false on those bodies — the OffsetSet propagation
  depends on the hashtable mirror.
* IsSlotSafe now takes a GlobalContext so call-site analysis can
  peek at the lazy-function table via LookupLazyByRef and flag
  callers of by-ref user functions as slot-unsafe.
* The vmcompiler.Compile call site threads ctx.Global() through.

Adds TestByRefParam exercising swap, value+ref return, and
\`\$arr[] = …\` writes through a by-ref array param.

The integration-test fallback sentinel now uses return-by-reference
(\`function &foo()\`), which still forces AST fallback.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

18 of 23 new or added lines in 4 files covered. (78.26%)

2 existing lines in 1 file now uncovered.

13930 of 115372 relevant lines covered (12.07%)

2045.19 hits per line