KarpelesLab / goro / 25771801761

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: user consts, typed return, destructure, var-vars, compound-expr, inc-dec non-local

Closes six AST fall-back triggers, each via the established
OpClassConst / OpTryFinally + OP_REFRESH_SLOTS pattern (and IsSlotSafe
extensions where needed):

* User-defined constants (PHP_INT_MAX, namespaced, define()-set, etc.)
  go through OpClassConst — resolution lives in the AST.
* Typed return (\`function f(): int { return \$x; }\`) AST-delegates
  the runReturn so coercion runs. Adjusts compile-func.go to stop
  skipping VM compile for return-typed closures.
* Short list / list() destructuring: \`[\$a, \$b] = \$arr\` and the
  keyword form both AST-delegate via the assign helper.
* Variable variables: \`\$\$name\` / \`\${\$expr}\` read/write.
* Compound assign as expression: \`\$y = (\$x += 1) * 2\` re-loads
  \$x after the native OpOpAssignLocal.
* ++/-- on non-variable targets: \$obj->prop++, \$arr[k]++, Foo::\$bar++
  AST-delegate via the assign helper; IsSlotSafe now flags T_INC/T_DEC
  alongside opD.write writes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

63 of 83 new or added lines in 5 files covered. (75.9%)

7 existing lines in 3 files now uncovered.

13116 of 115316 relevant lines covered (11.37%)

1949.91 hits per line