wboayue / rust-ibapi / 25766258915

92%

push

github

orders: type ExecutionFilter.side as Option<ExecutionFilterSide> (typed-status sweep PR 4b) (#570)

Promote ExecutionFilter.side from String to Option<ExecutionFilterSide>:
a #[non_exhaustive] two-variant enum (Buy, Sell) backed by impl_wire_enum!
(landed crate-wide in PR 4a). Empty wire becomes None; invalid filter
values (SSHORT, SLONG, Execution.side wire BOT/SLD, lowercase) are now
unrepresentable at compile time rather than reaching the server.

Wire vocabulary verified against C# ExecutionFilter.cs:47-49 ("BUY or
SELL"). Distinct from Action (outbound order side, which includes
SShort/SLong) — narrow filter-scoped enum prevents the cross-vocabulary
construction trap.

ExecutionFilter being outgoing-only means no inbound decoder is touched.
Encoder switches to some_display(filter.side.as_ref()) (PR 4a helper);
test_encode_execution_filter gains the previously-missing
assert_eq!(proto.side.as_deref(), Some("BUY")) assertion.

Sync doc-example at orders/sync/mod.rs updated to typed form. Async
orders/async/mod.rs::executions had no # Examples block (rule 18 gap);
added one using the SubscriptionItem pattern-match idiom from
accounts::positions and the consume form per
feedback_stream_adapter_consume_form.

Prelude re-exports ExecutionFilterSide in both feature-gated paths.
docs/migration-3.0.md gains §12 (before/after + Action distinction).

Test coverage: round-trip table (Buy/Sell) + reject-unknown including
the boundary cases — SSHORT/SLONG (Action vocabulary), BOT/SLD
(Execution.side wire, PR 5b territory), buy/sell (lowercase).

Closes the ExecutionFilter.side item in plans/typed-status-sweep.md PR 4.

14 of 14 new or added lines in 2 files covered. (100.0%)

18941 of 20598 relevant lines covered (91.96%)

26.97 hits per line