kubeflow / trainer / 25763132049
62%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 40
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 62.134%. Remained the same
25763132049

push

github

web-flow 
feat: storageuri targetjob validation fix (#3510)

* Applied the required changes

Signed-off-by: Pulkit Agrawal <97938993+pulkit-999@users.noreply.github.com>

* feat: add StorageUri and replicated job name validation

- Add CEL-based validation for StorageUri fields
- Relax URI regex to support minimal valid URIs
- Use DNS-1123 Pattern validation for replicated job names
- Add integration tests for validation
- Regenerate CRDs and update schema
- Align ModelInitializer documentation with validation rules

Signed-off-by: Pulkit Agrawal <97938993+pulkit-999@users.noreply.github.com>

* fix: use CEL validation for StorageUri and align fields

Signed-off-by: Pulkit Agrawal <97938993+pulkit-999@users.noreply.github.com>

* Potential fix for pull request finding

Valid

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pulkit Agrawal <97938993+pulkit-999@users.noreply.github.com>

* XValidation rule changes

Signed-off-by: Pulkit Agrawal <97938993+pulkit-999@users.noreply.github.com>

* fix: address review feedback for storageUri validation

Signed-off-by: Pulkit Agrawal <97938993+pulkit-999@users.noreply.github.com>

* Update pkg/apis/trainer/v1alpha1/trainjob_types.go

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Pulkit Agrawal <97938993+pulkit-999@users.noreply.github.com>

* fix: integration tests

Signed-off-by: Pulkit Agrawal <97938993+pulkit-999@users.noreply.github.com>

---------

Signed-off-by: Pulkit Agrawal <97938993+pulkit-999@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

2184 of 3515 relevant lines covered (62.13%)

0.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 25763132049.1 40
62.13
 GitHub Action Run
Source Files on build 25763132049