umputun / ralphex / 25756868348

83%

Build Type

push

github

Committed by web-flow

Commit Message

fix: tolerate plan file rename during execution (#342)

* feat: drop redundant move-plan checkbox from make_plan.txt

The framework already moves the plan to completed/ at end of run via
MovePlanToCompleted, gated by the move_plan_on_completion config option.
The LLM-task move was redundant and the source of mid-run rename risk
when the model wrote a different basename than the file on disk.

Add a tripwire test in pkg/config/prompts_test.go that asserts the
embedded template no longer contains any path-relocation substring
(move this plan, completed/, mv, relocate), catching reworded
re-introductions, not just the verbatim original.

Related to umputun/ralphex#341

* feat: tolerate renamed plan file during execution

When an LLM-driven task renames the plan file mid-run (e.g. dashed
YYYY-MM-DD-<slug>.md becomes compact YYYYMMDD-<slug>.md after a
git mv), the task loop used to spin forever: resolvePlanFilePath
fell back to completed/<exact-basename> only, hasUncompletedTasks
returned true on every ParsePlanFile error including fs.ErrNotExist,
and MovePlanToCompleted's idempotency check missed the renamed
destination.

Three layers of defense, all using the same dashed/compact swap:

- resolvePlanFilePath probes the alternate-format basename in both
  the original directory (in-place rename) and completed/ (moved
  and renamed) after the existing exact-basename probes.
- hasUncompletedTasks distinguishes fs.ErrNotExist from other
  parse errors and returns false when the file is truly gone,
  letting the ALL_TASKS_DONE signal exit the loop. Last-line-of-
  defense, runs after resolvePlanFilePath has exhausted all probes.
- MovePlanToCompleted treats a renamed destination as already-moved
  for idempotency. When the in-place renamed source collides with
  a stale completed/<altBase> copy, surface as already-completed
  and leave both files for manual resolution rather than clobbering.
- pkg/web/loadPlanWithFallback gets the same alt-format fallback
  so... (continued)

Coverage Stats

95 of 102 new or added lines in 5 files covered. (93.14%)

9 existing lines in 3 files now uncovered.

6974 of 8416 relevant lines covered (82.87%)

223.75 hits per line