KarpelesLab / goro / 25755510794

13%

push

github

vm: property write via AST delegation + OP_REFRESH_SLOTS

Adds an OP_REFRESH_SLOTS opcode that re-reads every local
from the FuncContext hashtable into the slot cache.
emitAssign now delegates \$obj->prop = v (and compound forms
like \$obj->prop += v that route through emitOperator's
write path) to the AST runner via the existing OpClassConst
/ OpTryFinally embeddings, then issues OP_REFRESH_SLOTS so
subsequent slot reads see locals modified through
ctx.OffsetSet during the delegation.

IsSlotSafe now rejects runOperator nodes that write to a
runObjectVar LHS — the AST delegation reads locals through
the hashtable, which has to be authoritative.

The 200+ lines of property-write semantics (typed
properties, hooks, asymmetric visibility, indirect-
modification notices, __set magic, readonly checks, …)
live in runObjectVar.WriteValue and we don't reimplement
them.

Tests cover: direct assign, method that writes \$this->p,
compound \$this->p += v, chained \$a = \$b = v, write-then-
read in the same expression. All pass.

phpt under GORO_VM=1: still 14 regressions, no new ones.
Now functions whose bodies contain property writes get
VM-compiled (other parts of the body run natively even if
the property-write statement delegates).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

19 of 24 new or added lines in 3 files covered. (79.17%)

10693 of 114917 relevant lines covered (9.3%)

1181.45 hits per line