python-discord / site / 25755183634
100%
master: 100%

LAST BUILD BRANCH: dependabot/uv/python-dotenv-1.2.2
DEFAULT BRANCH: master
Ran
Jobs 1
Files 101
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
25755183634

push

github

web-flow 
Replace gunicorn with waitress (#1614)

This commit replaces the `gunicorn` WSGI server with `waitress`. It
loses the statsd statistics, but gives us peace of mind.

The setup was tested by commenting out the `python manage.py run`
command in `docker-compose.yml`. Note that migrations need to be run for
the index page to work via `podman compose exec web -- python manage.py
migrate`.

Rationale
=========

Over the last few months, our dependency `gunicorn` has received a large amount
of contributions written primarily by the maintainer with close to zero external
review.

None of these implemented features are anything we need: dirty workers,
uWSGI protocol support, control socket, shared memory, ....  Nor do I
ever recall looking for any of these features in it.

The sheer volume of code and the general format of changes also strongly reeks
of LLM authorship or assistance.

Of course, every maintainer is free to do with their software whatever they
wish. But, as with any other dependency, I will evaluate any updates, keeping in
mind that any dependency we have here has full access to our database and API.

We do not need a WSGI server with regular feature development. We need one that
works and is maintained - that is the only requirement. See the linked
issue for more discussion.

Fixes: #1613

Signed-off-by: Johannes Christ <jc@jchri.st>

4634 of 4634 relevant lines covered (100.0%)

1.0 hits per line

Jobs
ID Job ID Ran Files Coverage
1 25755183634.1 101
100.0
 GitHub Action Run
Source Files on build 25755183634