wboayue / rust-ibapi / 25754225289

92%

push

github

contracts: type Contract.security_id_type as Option<SecurityIdType> (typed-status sweep PR 3b) (#568)

* contracts: type Contract.security_id_type as Option<SecurityIdType> (typed-status sweep PR 3b)

Promote Contract.security_id_type from String to Option<SecurityIdType>:
a #[non_exhaustive] five-variant enum (Cusip, Isin, Sedol, Ric, Figi)
backed by the impl_wire_enum! macro shipped in PR 3a. Empty wire becomes
None; unknown non-empty wire surfaces as Error::Parse instead of silent
raw-string storage (rule 16).

ContractBuilder::security_id_type changes from impl Into<String> to
SecurityIdType. The bond_cusip / bond_isin / bond(BondIdentifier::*)
constructors continue to set the field internally -- callers see no
signature change at those sites; just typed values internally.

Wire vocabulary verified: ISIN + FIGI appear in IBKR samples
(ContractSamples.cs:350,669); CUSIP/SEDOL/RIC come from the IBKR
secIdType reference doc. #[non_exhaustive] leaves room for IBKR
additions.

Tests use the PR 3a check_wire_enum_round_trip / check_wire_enum_rejects_unknown
helpers -- round-trip covers all five variants x Display+FromStr+ToField;
rejects-unknown covers empty + arbitrary + case-sensitivity. Existing
bond constructor tests and the contract-verify test_tables fixture
retyped through the new shape.

Closes the security_id_type item in plans/typed-status-sweep.md PR 3.

* /simplify pass: trim Contract.security_id_type field doc to match `right` precedent

The 5-line multi-paragraph doc on the field over-expanded vs the
adjacent `right: Option<OptionRight>` field (1 line). Compress to a
single line carrying the same cross-field invariant + example, with a
rustdoc cross-link to security_id.

All other /simplify findings either matched the OptionRight precedent
(variant doc-comments, derive shape, encoder bind-name, micro-opt
to_string vs as_str().to_owned()) or were known deferrals tracked in
plans/typed-status-sweep.md (some_display helper, verify.rs predicat... (continued)

30 of 30 new or added lines in 8 files covered. (100.0%)

18902 of 20560 relevant lines covered (91.94%)

30.39 hits per line