supabase / supabase / 25737601204

77%

push

github

Open advanced settings + scroll to that collapsible if submitting has an error (#45818)

## Context

Compute and Disk page: There's an odd scenario whereby down sizing the
compute might involve some validation errors in the advanced settings,
in which case because the advanced settings is in a collapsible and
requires the user to scroll down, there's hence no visual indication of
where the error is until the user opens the advanced settings to see the
inline error.

Am hence opting to open the advanced settings + scroll to it for this
particular scenario, if submitting the form causes a validation issue on
either IOPS, throughput or max disk size field inputs (the rest in this
section do not have validation checks on that afaict and hence wouldn't
be applicable to this scenario)

## To test

Can be tested locally
- Upsize compute to 8XL + change throughput to 750
- Once completed, try to down size to XL and hit "review changes"
- It should be clear from a UX POV if there are any errors

Also added an unrelated nit tidy up for ExitSurveyModal

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Advanced disk settings now auto-open and scroll into view (with a
brief delay) when validation errors occur for throughput, IOPS, or size,
improving error visibility.

* **User Interface**
* Improved advanced settings panel animation and separators for clearer
visual boundaries.
* Updated project deletion layout for the reason chooser and message
input, providing a more consistent form appearance.

[![Review Change
Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/45818)
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

938 of 1324 branches covered (70.85%)

Branch coverage included in aggregate %.

1442 of 1996 relevant lines covered (72.24%)

249.49 hits per line