stacklok / toolhive / 25732466600

66%

Build Type

push

github

Committed by web-flow

Commit Message

Collapse registry provider error ladder into a helper (#5261)

The same `errors.As` ladder for `*LegacyFormatError`,
`*UnavailableError`, plus the `auth.ErrRegistryAuthRequired` check was
copy-pasted across `getCurrentProvider`, `listRegistries`,
`getRegistry`, `listServers`, and `getRegistryProvider`. Each new
error code that needs structured handling had to be wired into five
places, and the existing v0.1 router did the same `errors.Is` check
inline instead of going through `isRegistryAuthError`.

Extract a single `writeProviderError(w, err) bool` helper that
handles all three known failure modes and returns whether a response
was written. Each callsite collapses to two lines and a generic
fallback. Drop the now-unused `errors` and `registry/auth` imports
from `registry_v01.go`.

Also lower the legacy-format log to `slog.Warn`: it signals a user
misconfiguration that the API has already translated into a 502 with
an actionable hint, not a server-side failure that on-call should
investigate. The upstream-unavailable path stays at `slog.Error`
since it usually does indicate a real outage.

Improves on #5260

Coverage Stats

15 of 23 new or added lines in 2 files covered. (65.22%)

2 existing lines in 1 file now uncovered.

64179 of 98544 relevant lines covered (65.13%)

62.51 hits per line