stacklok / toolhive-studio / 25725621879

70%

Build Type

push

github

Committed by web-flow

Commit Message

feat(api): migrate thv API transport from HTTP to UNIX socket / Windows named pipe (#1694)

* feat(api): move from http to socket

* fix(api): re-register IPC fetch handlers cleanly on dev hot reload

* chore: add start:inspect script for main-process network inspection

* test(toolhive-manager): align tests with socket-based startToolhive

* test(e2e): route thvFetch through UNIX socket via http.request

* fix(api): route main-process workload clients through socket transport

Three sites in main were still building http://localhost:${port} for the thv API: fetchWorkloads() in chat/mcp-tools.ts, the workload-validation step in chat/settings-storage.ts, and defaultBuildClient() in chat/agents/builtin-agent-tools/skills.ts. After the socket migration getToolhivePort() returns undefined for the managed thv, so those calls hit http://localhost:undefined and threw — silently breaking the playground MCP-tools toggle (handleToggleTool catches and toasts), the post-install MCP-tools cleanup, and the skills agent.

Add createMainProcessApiClient() and hasToolhiveConnection() helpers in unix-socket-fetch.ts that wrap createMainProcessFetch(). Callers get a hey-api Client with the live transport (socket or TCP fallback) without having to know which one is in use; the baseUrl is a sentinel that the custom fetch ignores.

Replace the three call sites with the helper. Surfaced by playground.spec.ts which used to time out waiting for the 'N tools' badge after enabling an MCP server.

* feat(toolhive-manager): use Windows named pipes for thv socket transport

Windows AF_UNIX sockets created in %TEMP% fail with EACCES on connect because of the DACLs Go's os.Chmod(0660) sets in pkg/api/server.go — same-user access is not enough on common Windows builds. Named pipes are the canonical Windows IPC (Podman Desktop uses the same approach), have no filesystem ACL semantics to fight, are released by the kernel when the listener closes, and are accepted by Node's http.request... (continued)

Coverage Stats

4766 of 7529 branches covered (63.3%)

133 of 149 new or added lines in 15 files covered. (89.26%)

17 existing lines in 3 files now uncovered.

7148 of 10443 relevant lines covered (68.45%)

119.51 hits per line