wboayue / rust-ibapi / 25716583682

92%

Build Type

push

github

Committed by web-flow

Commit Message

contracts/types: impl_wire_enum! macro (typed-status sweep PR 3a) (#564)

* contracts/types: impl_wire_enum! macro (typed-status sweep PR 3a)

Dedupe Display/FromStr/ToField boilerplate for typed-status enums into
a single impl_wire_enum! macro. Each enum keeps as_str() + from_wire()
inherent (the data tables), the macro derives the three trait impls.

Orphan rule blocks a blanket impl<T: WireEnum> Display, so macro is the
only way to deduplicate (rule 25). Three current consumers — OptionRight
and LegAction retrofitted here; SecurityIdType lands in PR 3b. PR 4
(ExecutionFilterSide) and PR 5b (ExecutionSide) inherit the shape.

Test helpers check_wire_enum_round_trip<T> and check_wire_enum_rejects_unknown<T>
collapse the per-enum test shape — one helper covers Display + FromStr +
ToField round-trip in one loop, so the dedicated to_field tests are
deleted (covered transitively).

Zero behavior change. Public API unchanged.

* /simplify pass: tighten visibility + drop redundant assertions

- from_wire on OptionRight and LegAction: pub(crate) -> private (only
  consumer is the impl_wire_enum! macro expansion in the same module)
- impl_wire_enum! doc: drop overclaiming "every typed-status enum"
  language and the "(CLAUDE.md rule 25)" parenthetical (internal jargon
  on docs.rs surface)
- from_wire bodies: flip Some(match { _ => return None }) to idiomatic
  match { => Some(), _ => None }
- check_wire_enum_round_trip: drop redundant format!() assertion (same
  trait path as to_string())

Follow-up tracked: OrderStatusKind in src/orders/mod.rs is shape-identical
to the macro target -- adopt in a follow-up.

Coverage Stats

20 of 20 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

18840 of 20543 relevant lines covered (91.71%)

27.36 hits per line