Qiskit / qiskit / 25714853195

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Improve single-qubit gate count in `TwoQubitControlledUDecomposer` (#16123)

* add a function append_1q_sequence

* use append_1q_sequence function

* reduce 1-qubit gtaes, need to debug failing tests

* update matrix calculation. still need to fix failing tests

* minor fix

* fix bugs, tests are passing now!

* rename gates1 to weyl_gates

* fix clippy errors

* move H, S, SDG matrices to common

* simplify append_1q_sequence, remove invert_1q_gate

* add tests for the number of gates

* add another test

* invert matrices inplace using try_inverse_mut

* add release notes

* not inverting the k matrices twice

* invert the RXX equivalent gate in to_rxx_gate

* handle weyl_gate.global_phase

* only create the euler_basis once

* to_rxx_gate returns only one 2-qubit gate, or its inverse

* minor update to test

* the two qubit indices are only [0,1]

* update panic error

* modify k_mats in place

* add circuit pictures

* Use a struct instead of a tuple for result objects

This commit updates the result type usec internally between the
to_rxx_gate() function and it's caller to be a struct instead of a
4-tuple. This allows named access and makes it easier to reason about
about what each of the fields are and give them context.

* Rename variables for clarity

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Coverage Stats

190 of 196 new or added lines in 1 file covered. (96.94%)

11 existing lines in 4 files now uncovered.

107019 of 122141 relevant lines covered (87.62%)

960844.63 hits per line