ponder-lab / Hybridize-Functions-Refactoring / #1241

71%

main: 72%

Pull #463

travis-pro

Address PR review: invariant throw, defensive assert, manifest version alignment.

Per Copilot review on PR #463:

- `Parameter.getTensorTypes` (`r3223185885`): restore the invariant the prior `Function.tensorAnalysisIncludesParameter` enforced — if the matching `PointerKey` is present but the `TensorVariable` is null, this is an Ariadne-side invariant violation. Throw `IllegalStateException` rather than silently skipping.
- `testInferredTensorTypes` (`r3223185900`): assert `lastTensorTypeAnalysis != null` before passing it to `Parameter.getTensorTypes(...)` (which now `requireNonNull`s the analysis). Fails the test cleanly with a directed message instead of NPE.
- `core/META-INF/MANIFEST.MF` (`r3223185915`, `r3223185935`): bump `com.ibm.wala.cast.python.ml.analysis` from the stale `0.16.0` pin to `0.29.0` to match every other Ariadne-package import in the core bundle (and the test bundle's same-package import). The `0.16.0` predates the design work here (introduced in `b3e22b7` "Upgrade to Ariadne 0.21.0-SNAPSHOT") but the test-bundle import added by this PR makes the inconsistency visible.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

115 of 133 new or added lines in 2 files covered. (86.47%)

1102 of 1553 relevant lines covered (70.96%)

0.71 hits per line