wboayue / rust-ibapi / 25702016955

92%

push

github

contracts: type ComboLeg.action as LegAction (typed-status sweep PR 1) (#556)

* contracts: type ComboLeg.action as LegAction (typed-status sweep PR 1)

Land shared parse_required/parse_optional helpers in proto/decoders.rs
and convert the first sweep target: ComboLeg.action: String -> LegAction
(extended with SellShort; SLONG deliberately excluded since combo legs
do not accept it per the C# reference).

Decoders for combo_leg/contract/contract_details become fallible -
malformed wire surfaces as Error::Parse instead of silent fallback to
LegAction::default() (rule 16). 9 callsites updated with .transpose()?.

parse_order_status removed; the 2 callers now use parse_required directly
to keep the sweep uniform.

* docs(plans): track typed-status PR 1 shipped + two follow-ups

- §2 typed-status sweep: mark PR 1 shipped (PR #556); fold OptionRight
  test-shape modernization into PR 2 scope.
- §5 Errors: track Error::Parse(usize, ...) index-slot redesign — five
  fake-`0` sites accumulate by PR 5; decide before then.

* docs(plans): mirror PR 1 follow-ups into typed-status-sweep.md

Cross-reference the v3-api-ergonomics.md follow-ups at the point of action:
- PR 2 scope: fold the OptionRight test-shape modernization.
- Cross-cutting: Error::Parse index slot redesign before PR 5.

* trim narrating comments

- LegAction::SellShort variant doc: drop the gate/floor sentence that
  repeats the type-level doc.
- parse_optional: drop the '// First consumer lands in PR 2' attribute
  comment that narrated PR sequencing.

74 of 74 new or added lines in 9 files covered. (100.0%)

18685 of 20636 relevant lines covered (90.55%)

25.48 hits per line