kubeflow / trainer / 25701250948
62%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 40
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 62.134% (+0.3%) from 61.849%
25701250948

push

github

web-flow 
chore(test): add unit tests for trainingruntime and trainjob utilities (#3370)

* test(util): add unit tests for trainingruntime and trainjob utilities

Fixes #3152

pkg/util/trainingruntime (0 percent to 100 percent coverage):
- New trainingruntime_test.go with 8 cases for IsSupportDeprecated
  covering nil, empty, absent key, wrong value, empty value,
  correct deprecated, multiple labels, and partial match edge case.

pkg/util/trainjob (extended):
- TestRuntimeRefIsClusterTrainingRuntime: 4 new edge cases added
  covering wrong APIGroup, nil APIGroup, nil Kind, both nil.
- TestIsTrainJobFinished: 6 new cases covering all condition states.
- Added metav1 import required for Condition status constants.

Signed-off-by: Yugendhar S <yugendhars06@gmail.com>

* chore(test): address review feedback from andreyvelich

- Remove year from Copyright headers in both test files
- Add trailing newline at end of both files
- Fix error message format in TestRuntimeRefIsTrainingRuntime
  to use 'FunctionName(%v) = %v, want %v' pattern for consistency
- Add nil edge cases to TestRuntimeRefIsTrainingRuntime for symmetry
  with TestRuntimeRefIsClusterTrainingRuntime (nil APIGroup, nil Kind,
  both nil, wrong APIGroup)

Signed-off-by: Yugendhar S <yugendhars06@gmail.com>

* chore(test): fix line endings and formatting for CI

Signed-off-by: Yugendhar S <yugendhars06@gmail.com>

---------

Signed-off-by: Yugendhar S <yugendhars06@gmail.com>

2184 of 3515 relevant lines covered (62.13%)

0.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 25701250948.1 40
62.13
 GitHub Action Run
Source Files on build 25701250948