stacklok / toolhive-studio / 25700062916

69%

main: 70%

Build Type

Pull #2217

github

Committed by reyortiz3

Commit Message

fix(main): prevent orphaned thv serve when parent exits before SIGKILL timer

stopToolhive() nulled the module-level toolhiveProcess reference immediately
after sending SIGTERM and schedule SIGKILL via setTimeout. When Electron's
parent process exited before the 2s timer fired, the synchronous
process.on('exit') handler called stopToolhive({ force: true }) but it
short-circuited on !toolhiveProcess, leaving the child alive and blocking
the next launch's port.

Hold the reference until the child's 'exit' event fires (tracked via a new
isStopping flag for isToolhiveRunning) so the synchronous parent-exit force
kill actually SIGKILLs the orphaned PID. Guard the exit handler against
clobbering a fast-restart's new spawn.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #2217: fix(main): prevent orphaned thv serve when parent exits before SIGKILL timer

Coverage Stats

4716 of 7483 branches covered (63.02%)

16 of 16 new or added lines in 1 file covered. (100.0%)

8 existing lines in 1 file now uncovered.

7038 of 10354 relevant lines covered (67.97%)

120.52 hits per line