esnet-security / SCRAM / 25681748903

90%

develop: 94%

push

github

ci(tests): Cleanup workflow runs (#231)

This PR cleans up our workflows to run on a per-app basis and upload
things in the same manner. It also renames all of the make targets to
`test-application` to get ride of behave vs pytest and all the confusion
there. Now it just runs the tests for one of the applications. You can
still call pytest and behave but the targets are all simplified. I also
added a (neutral) type-check workflow.. It fails all the time (so we
ignore that) but I want to run type checking in the future so I figure
this gets us to where it's ready to remove || true once we fix type
checking errors in the code base.

Finally, this adds a make target `ci-act` (`act` needs to be installed
via brew locally) which allows you to test GH actions locally. Works
pretty well.

I also restructured the Makefile. It was way too out of order and the
names didn't make sense anymore as we've scaled things. Changes are:

Renamed:

1. behave-all to behave-django (it was all for ALL features (in django
only lol)
2. behave to behave-django-feature (keeping this around but I feel like
we should get rid of it or make it generic enough to work for translator
behave too)
3. integration-tests	to integration-django
4. pytest to pytest-django
6. pytest-scheduler to test-scheduler
7. pytest-scripts to test-scripts

Removed:

1. coverage.xml . We now just have per-app coverage steps inside the
test targets. And we just now always run coverage cuz it's not that big
a deal to do.

Added/Significantly modified: 

behave-translator. This wasn't added, but now it has coverage, doesn't
just run tests.
test-django. runs all tests for django (pytest-django + behave-django +
integration-django)
test-translator:  builds/runs stack + runs behave-translator
test: runs all four test-* targets (so in theory ALL test types)
ci-test: runs all CI workflows locally via act (old ci-test didn't
mirror CI at all).
behave-translator-feature. Allows you to run just one behave feature for... (continued)

69 of 81 branches covered (85.19%)

Branch coverage included in aggregate %.

1302 of 1436 relevant lines covered (90.67%)

0.91 hits per line