wboayue / rust-ibapi / 25679410018

92%

Build Type

push

github

Committed by web-flow

Commit Message

contracts/types: lift test coverage to 99.6% lines (#554)

* contracts/types: lift test coverage to 99.6% lines

Extract pure helpers next_friday_from / third_friday_from / front_from /
next_quarter_from so date-dependent branches are testable with synthetic
dates. Add tests for the string-newtype surface (new/as_str/From/Display/
ToField/serde round-trip), OptionRight, LegAction, Strike (positive /
non-positive / panic), ExpirationDate (every weekday + Display +
month-roll), ContractMonth (front + every next_quarter arm),
BondIdentifier, and Missing.

Coverage: lines 61.4% → 99.6%, functions 64.3% → 100%, regions 61.9% →
99.7%. Only remaining uncovered region is the u8-exhaustivity `_ => 3`
arm in next_quarter_from (unreachable).

* contracts/types: /simplify pass

- Fold the redundant string_newtype_new_monomorphizations! macro into
  string_newtype_surface! — surface now covers both new(&str) and
  new(String) monomorphizations in one place.
- Replace local fn date(y,m,d) helper with the project-standard
  time::macros::date!(YYYY-MM-DD) literal.
- Drop WHAT-narration comments inside the test bodies (test names and
  literal values are self-documenting).
- Drop the stale `// If today is Friday, get next Friday` inline
  comment in next_friday_from — redundant with the Weekday::Friday arm.
- Rename bond_identifier_variants_round_trip → ..._equality_and_match
  (the body constructs and pattern-matches; no serde round-trip).

No coverage regression: lines 99.6%, functions 100%, regions 99.7%.

* docs(CLAUDE.md): rule 25 — macros only when ordinary Rust can't

* contracts/types_tests: demote serde_round_trip! and str_eq_round_trip! to generic helpers

Per the new rule 25 in CLAUDE.md: macros are only justified when the
body relies on something that doesn't compose generically (inherent
methods, struct-literal access, etc.). Both macros here use only trait
methods, so a generic helper + thin per-type #[test] fn wrappers gives
the same independent pass/f... (continued)

Coverage Stats

16 of 16 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

18577 of 20575 relevant lines covered (90.29%)

25.63 hits per line