extphprs / ext-php-rs / 25676991317

66%

master: 66%

Pull #735

github

test: regression coverage for ZendClassObject<T> set_zval refcount leak

Adds an integration test that exercises the exact buggy code path
fixed in the previous commit: a class extending \Exception with a
#[php(prop)] field, constructed via ZendClassObject::new(...)
.into_zval(...) and thrown via PhpException::with_object. The
caught exception's refcount is read inside the catch block via
debug_zval_dump; with the fix the only holder is the catch-bound
variable, so the dump reports refcount 2. Without the fix the
buggy set_zval keeps an extra ref and the dump reports 3.

Refcount via debug_zval_dump was chosen over a memory-growth
measurement so the same assertion fires on release and debug PHP
builds. memory_get_usage / gc_collect_cycles interact poorly with
a separate latent refcount bug in the IntoZval impl for
&mut ZendClassObject<T> (out of scope here): on debug builds GC
tries to add to a shared HT and trips
_zend_hash_str_add_or_update_i.

Verified against PHP 8.4.20 NTS and 8.4.20 ZTS-DEBUG: passes
with the fix, fails (refcount 3) without it.

0 of 4 new or added lines in 2 files covered. (0.0%)

8653 of 13065 relevant lines covered (66.23%)

33.26 hits per line