ghga-de / datahub-file-service / 25661728617

82%

main: 82%

Build Type

push

github

Committed by web-flow

Commit Message

Polish logging (GSI-2307) (#12)

* Suppress most logs and trim traceback where not necessary

* Clean up the cleanup logs a little more

* Expand list of suppressed loggers and update tests

* Bump version to 1.0.4

* Add config options to control library log output

* Rename loggers_to_suppress to library_logger_names

* Rework logging - still work to do

* Restructure error definitions and rework most logging

* Update template files and docs

* Bump minor version because of new config options

* Inline the upgrade required error

* Put bucket back in log

* Expand message in log about aborting already aborted upload

* Remove unused config param and related todo

* Log failed deletion object IDs in cleanup command

* Make log message in cleanup much nicer, more better

* Change log to info when deleting existing object before starting upload

* Extract file upload abort code to private method

* Move msg into error class for some errors

* Remove debug logs that don't help

* Start object-centric messages with object id

* Remove UploadURLMissingUploadError and document other logs

* Remove logging of errors in S3Client module

* Enhance error text

* Make sure happy case file removal log doesn't follow unhappy case log

* Re-raise error as inconclusive error to be consistent

* Add word to error message

* Use fixed messages for UploadCompletionError and DownloadError and use S3OperationError for catch-all in S3Client

* Fix doc string for _configure_logging()

* Add missing bucket check to get_is_file_in_inbox

* Remove unused error class from except clause

* Swap sys exit for return

* Explicitly translate critical errors at call sites instead of at top

* Remove anomalous warning log for DownloadError and consolidate info a layer up

Coverage Stats

153 of 229 new or added lines in 12 files covered. (66.81%)

12 existing lines in 4 files now uncovered.

696 of 852 relevant lines covered (81.69%)

0.82 hits per line