supabase / cli / 25658247275
64%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 219
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 63.747% (+0.002%) from 63.745%
25658247275

push

github

web-flow 
fix(cli): drop full-request timeout from service gateway uploads (#5210)

## Summary

- Removes the 10s `http.Client.Timeout` from `NewServiceGateway` and
`NewKongClient` so streaming storage uploads no longer fail with
`Client.Timeout exceeded while awaiting headers` under load.
- The cap was inherited from the tenant-API health-check client when
`NewServiceGateway` was extracted in #3929; it was never chosen for
storage uploads. The active client for local seed (`newLocalClient` →
`NewKongClient`) carries the same anti-pattern, so both are addressed.
- Connection setup is still bounded by the default transport's dial /
TLS-handshake timeouts, and per-call deadlines continue to flow through
the request `Context`.

Fixes
[CLI-1441](https://linear.app/supabase/issue/CLI-1441/storage-uploads-can-time-out-after-10-seconds).

## Why

`http.Client.Timeout` covers dial + send + waiting for response, so a
single small upload taking >10s for the server to ack would surface as a
hard failure. `supabase seed buckets --linked` already worked because
`newRemoteClient` overrides the gateway client with `http.DefaultClient`
(no timeout); the local path through Kong did not.

## Test plan

- [x] `go test ./internal/utils/tenant/ ./internal/storage/client/
./internal/status/` (all pass)
- [x] `go vet` clean for both touched packages
- [ ] Manual repro: re-run the proxy-delay scenario from the issue and
confirm the upload completes instead of timing out at 10s.

---
_Generated by [Claude
Code](https://claude.ai/code/session_01QFScBK1kF6twDYjraZ2hQm)_

---------

Co-authored-by: Claude <noreply@anthropic.com>

9993 of 15676 relevant lines covered (63.75%)

7.06 hits per line

Coverage Regressions

Lines Coverage ∆ File
16
77.5
 0.09% internal/status/status.go
2
80.61
 0.0% internal/storage/rm/rm.go
Jobs
ID Job ID Ran Files Coverage
1 25658247275.1 219
63.75
 GitHub Action Run
Source Files on build 25658247275