KarpelesLab / libwallet / 25651787242

24%

push

github

wltacct/solana: write the signature into the signer's slot, not slot 0

solanaInsertSignature unconditionally wrote into signature slot 0. For
sponsored transactions the relay (feePayer) holds slot 0 and the wallet
owner is at slot 1+, so the owner's signature was clobbering the
relay's slot. The relay then re-signed slot 0 with its own key,
overwriting the owner's signature, leaving slot 1 all zeros — Solana
rejected the tx with "missing signature for account 1" and the client
hung polling for a confirmation that never arrived.

Walk the message's account-keys array to find which slot matches the
signer's pubkey, and write the signature there. Reject if the pubkey
isn't a required signer for this transaction. Handles both legacy and
v0 versioned messages.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

44 of 66 new or added lines in 2 files covered. (66.67%)

3253 of 15354 relevant lines covered (21.19%)

123.2 hits per line