wboayue / rust-ibapi / 25651742093

92%

push

github

notice: add NoticeCategory + is_order_rejection helper (#551)

* notice: add NoticeCategory + is_order_rejection helper

Add typed classification on Notice mirroring OrderStatusKind::is_terminal
(PR #518). New API:
- ORDER_REJECTION_CODE_RANGE const (200..=399)
- NoticeCategory enum (non_exhaustive; 5 variants)
- Notice::is_order_rejection()
- Notice::category() -- disjoint partition with precedence
  Cancellation > Warning > SystemMessage > OrderRejection > Error

Closes v3-api-ergonomics.md section 2 notice classification item.

* notice/tests: extract notice_with_code helper

/simplify pass: 3 identical Notice struct literals across the two new
tests collapse to one helper. Loop bodies become one-line assertions.

* notice: trim duplicative doc-comments

/simplify pass:
- Drop "excluding 202 by precedence" from OrderRejection variant comment;
  precedence already documented at the enum level.
- Drop the transport-routing paragraph from is_order_rejection rustdoc;
  it leaks implementation detail and rots if routing evolves. Keep the
  load-bearing overlap-with-202 note.

* docs(plans): mark notice classification in progress (#551)

14 of 14 new or added lines in 1 file covered. (100.0%)

18430 of 20568 relevant lines covered (89.61%)

33.61 hits per line