Tatsh / wiswa / 25646753383

100%

push

github

extensions: tolerate missing `priority` when sorting custom badges

`docs/badges.rst.j2` and `README.md.j2` both sort
`settings.custom_project_badges` with
`sort(attribute='priority')`. Under `StrictUndefined`, Jinja2's
built-in sort raises `UndefinedError` if any entry lacks the
attribute, so projects that define `custom_project_badges` without an
explicit `priority` (a contract the surrounding `< 0` / `>= 0` guards
already treat as defaulting to `0`) crashed at render time:

  jinja2.exceptions.UndefinedError: 'dict object' has no attribute
  'priority'

Add a `sort_dicts(value, key, default=0)` Jinja2 filter (new
`SortDictsExtension`) that sorts an iterable of mappings by a key and
falls back to the supplied default when the key is absent, mirroring
`sort(attribute=...)` but without the strict-undefined cliff. Switch
the two badge templates to use it; entries without `priority` now sort
into the `>= 0` group alongside the other default-priority badges,
matching the existing render-time guards.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

485 of 485 branches covered (100.0%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

2513 of 2513 relevant lines covered (100.0%)

5.0 hits per line