adierking / unplug / 25621452374

77%

Build Type

push

github

Committed by adierking

Commit Message

asm: Always sign-extend expression values

I wasn't satisfied with the previous change sometimes emitting `Imm32` for a
value with a `.w` suffix. So, instead, always sign-extend values with explicit
sizes in expressions:

- `255.b` becomes `-1.b`
- `65535.w` becomes `-1.w`
- `255` (no suffix) becomes `255.w`
- `65535` (no suffix) becomes `65535.d`

If sign extension occurs, the user will be given a warning to drop the type
suffix because they probably didn't intend this.

Since the disassembler always reads expression values as signed, this will not
affect the assembly of the vanilla game scripts, however this may be a breaking
change for user code.

Coverage Stats

13 of 25 new or added lines in 2 files covered. (52.0%)

71 existing lines in 3 files now uncovered.

19023 of 24662 relevant lines covered (77.13%)

1070285.23 hits per line