dangernoodle-io / TaipanMiner / 25620234720

90%

push

github

refactor(diagnostics): extract sse + telemetry state machine; add tests (#375)

* refactor(webui): extract diagnostics page state machine

- extract diagnosticsHelpers.ts: filterLines, retryInSeconds, findLevelForTag (pure functions)
- extract diagnosticsState.svelte.ts: full sse + telemetry + log-level + reboot state machine
- diagnostics.svelte shrinks to thin shell; all logic delegated to createDiagnosticsState()
- convert $: blocks to $derived; mutated locals to $state; $state.raw for sse/timer identity
- sse lifecycle: init() wires intervals and visibility listener; destroy() tears down in order
- behavior unchanged: same state transitions, same message strings, same sse semantics

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* test(webui): cover diagnostics state machine and helpers

- diagnosticsHelpers.test.ts: 12 specs covering filterLines, retryInSeconds, findLevelForTag
- diagnosticsState.test.ts: 58 specs covering init/destroy lifecycle, loadDiagAsic/loadLevels,
  applyLevel, doReboot/requestReboot, clear, all SSE callbacks (onMessage cap, onStatusChange,
  onRetryAtChange, onOpen reconnect logic), onPanelScroll, onVisibilityChange, $derived computed
  properties (filtered, currentLevel, retryInS), and setter round-trips
- diagnostics.test.ts: rewritten as thin render-specs using createDiagnosticsState mock;
  covers conditional rendering (drops table, empty state, status labels, filter hint),
  button states, and error message display
- removed $effect from state machine (effect_orphan in test context); replaced with
  imperative syncSelectedLevel() called after loadLevels and selectedTag setter

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

2201 of 2883 branches covered (76.34%)

Branch coverage included in aggregate %.

188 of 193 new or added lines in 3 files covered. (97.41%)

4211 of 4524 relevant lines covered (93.08%)

182525.23 hits per line