wboayue / rust-ibapi / 25618672738

92%

Build Type

push

github

Committed by web-flow

Commit Message

chore(orders): drop text branches in OpenOrder/CompletedOrder decoders (#539)

* chore(orders): drop text branches in OpenOrder/CompletedOrder decoders

`decode_open_order` and `decode_completed_order` are now proto-only via
`ResponseMessage::require_proto` — text framing skip-classifies via
`Error::UnexpectedResponse` (rule 20). Originating outgoing-request gates
(`PROTOBUF_PLACE_ORDER` = 203, `PROTOBUF_COMPLETED_ORDER` = 204) sit at or
below the connection floor of 210 (`PROTOBUF_SCAN_DATA`). C# `EDecoder.cs`
confirms the dispatch is purely on the 4-byte msg-id framing.

Deleted ~750 lines of `OrderDecoder` (text-decoder helper struct), both
`*_text` decoder bodies, all 6 condition text decoders
(`decode_{price,time,margin,execution,volume,percent_change}_condition`),
and the `decode_open_order_borrowed` adapter (now redundant — the public
decoder takes `&mut ResponseMessage` directly). `server_version` parameter
dropped from both decoders and from all 6 stream-decoder dispatch arms in
`stream_decoders.rs`.

`orders/common/test_data.rs` (6 verbatim-captured pipe-delimited fixtures)
deleted.

Builders: added field-minimal `OpenOrderResponse` (TSLA STK defaults) and
`CompletedOrderResponse` (AAPL STK Filled defaults) over `proto::OpenOrder`
/ `proto::CompletedOrder` in `testdata/builders/orders.rs`. Setters expose
the ~20 fields tests assert on; deeply-nested Contract/Order/OrderState
proto submessages are populated via private helper fns.

Tests: dropped 11 text-fixture unit tests + 7 condition round-trip tests
from `decoders/tests.rs`; added 2 builder→production-decoder integration
tests + `*_rejects_text_framing` regression guards for OpenOrder and
CompletedOrder. Sync `place_order` / `completed_orders` field-by-field
asserts (100+ fields each) trimmed to key-field checks — proto decoder is
unit-tested separately. Async tests migrated to proto fixtures.

Tracker `plans/legacy-text-protocol-cleanup.md` updated; orders row drops
to 0 text decoders + ... (continued)

Coverage Stats

294 of 316 new or added lines in 4 files covered. (93.04%)

40 existing lines in 4 files now uncovered.

18002 of 20114 relevant lines covered (89.5%)

25.96 hits per line