radio-t / stream-recorder / 25616554810

75%

master: 75%

Build Type

Pull #25

github

Committed by paskal

Commit Message

Add post-recording VBR header fix to recorded MP3s

Recorded MP3s have variable bitrate (icecast source mixes 32-128 kbps
frames depending on speech vs silence) but no Xing/Info VBR header.
Without that header, players estimate duration from the first frame's
bitrate, which is wildly wrong: a 3h15m recording shows up as 8h42m in
Apple/Safari, and seeking past the real audio end stalls the player.

Fixed by remuxing the file with `ffmpeg -c copy -f mp3` after chapter
injection. ffmpeg adds a proper Xing header (frame-counted duration),
preserves all ID3 tags including the CHAP/CTOC frames, and doesn't
re-encode (~1s for a 140 MB file).

The post-processor no-ops cleanly when ffmpeg isn't on PATH, so dev/test
runs without the dependency still work.

Pull Request Pull Request #25: Add post-recording VBR header fix to recorded MP3s

Coverage Stats

16 of 26 new or added lines in 2 files covered. (61.54%)

120 existing lines in 4 files now uncovered.

796 of 1041 relevant lines covered (76.46%)

6.18 hits per line