graphql-go / graphql / 1890

86%

master: 92%

Build Type

Pull #740

circleci

Committed by Nthalk

Commit Message

fix: ExecutePlan uses the plan-bound schema, not p.Schema

Plan documents itself as bound to plan.schema — sub-plans,
abstractAlternatives, and field defs are all keyed off the *Object
pointers from the plan-time schema. ExecutePlan was reading p.Schema
for getVariableValues and the executionContext, so a caller passing
an ExecuteParams.Schema that diverged from the planned schema (e.g.
a rebuilt schema with the same shape but different *Object
pointers, different IsPossibleType set, or different extensions)
would silently coerce variables and resolve abstract types against
the wrong schema while sub-plans still ran against the original.

Use *plan.schema for both, so the binding documented at the top of
Plan is actually enforced.

Pull Request Pull Request #740: Plan + PlanQuery + ExecutePlan + PlanCache (cacheable execution shape)

Coverage Stats

823 of 1065 new or added lines in 4 files covered. (77.28%)

406 existing lines in 1 file now uncovered.

5830 of 6935 relevant lines covered (84.07%)

265.64 hits per line