wboayue / rust-ibapi / 25607650839

92%

push

github

chore(contracts): drop text branches in 4 contract decoders (#534)

* chore(contracts): drop text branches in 4 contract decoders

`decode_contract_details`, `decode_contract_descriptions`,
`decode_market_rule`, and `decode_option_chain` are now proto-only via
`ResponseMessage::require_proto` — text framing skip-classifies via
`Error::UnexpectedResponse` (rule 20). All originating
outgoing-request gates (`PROTOBUF_CONTRACT_DATA` = 205) sit at or below
the connection floor of 210 (`PROTOBUF_SCAN_DATA`), so the server always
emits these in proto framing. C# `EDecoder.cs` confirms the dispatch is
purely on the 4-byte msg-id framing — no `if server_version >=` guards.

Deleted `decode_contract_details_text` (~130 lines) plus the helpers it
relied on (`split_hours`, `split_to_vec`, `read_last_trade_date`) — no
other callers. `decode_option_computation` stays text-framed: it's
shared with `market_data/realtime` (gate 206) and gets dropped in that
family's cleanup PR.

Tests: 7 text-decode unit tests + 3 helper tests deleted from
`decoders/tests.rs`; 4 `*_rejects_text_framing` regression guards added.

Builders: added `ContractDataResponse`, `SymbolSamplesResponse` (+
`SymbolSamplesEntry`), `MarketRuleResponse`, `OptionChainResponse` to
`testdata/builders/contracts.rs`. The `ContractData` builder mirrors the
deeply-nested `proto::Contract` + `proto::ContractDetails` shape with
fluent setters for the fields exercised by tests.

Test fixture migration: renamed `response_messages: Vec<String>` →
`ordered_responses: Vec<ResponseMessage>` on `ContractDetailsTestCase`,
`MatchingSymbolsTestCase`, `MarketRuleTestCase`, `OptionChainTestCase`,
`StreamDecoderTestCase`, `ContractDetailsErrorTestCase`. All
ContractData / SymbolSamples / MarketRule /
SecurityDefinitionOptionParameter fixtures rebuilt via proto builders.
3 inline raw-text fixtures in `contracts/async/tests.rs` (request_stock
/ future / bond_contract_details) converted to proto. End markers (msg
52 / msg 76... (continued)

536 of 536 new or added lines in 3 files covered. (100.0%)

18429 of 20758 relevant lines covered (88.78%)

25.68 hits per line