go-sql-driver / mysql / 25598140030

83%

master: 83%

Build Type

Pull #1768

github

Committed by Nghĩa Nguyễn Ngọc

Commit Message

dsn: use last colon before '@' as user/password separator

ParseDSN was using the first colon before '@' as the separator between
username and password. This prevented usernames containing colons from
being represented in the DSN.

The DSN format already handles multiple ambiguous delimiters by scanning
from the right (e.g. the last '/' for the database name, the last '@'
for the credentials boundary). Apply the same right-to-left strategy
for the colon: use the last ':' before '@' as the user/password split
point so that usernames like "domain:user" work correctly.

Fixes #1747

Pull Request Pull Request #1768: dsn: use last colon before '@' as user/password separator (fixes #1747)

Coverage Stats

8 of 8 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

3380 of 4091 relevant lines covered (82.62%)

2621754.86 hits per line