25601641224
71%

Ran 09 May 2026 12:55PM UTC

Jobs 4

Files 24

Run time 1min

Badge

Embed ▾

Committed 09 May 2026 12:54PM UTC coverage: 71.28% (-0.2%) from 71.44%

Build # 25601641224

Build Type

push

github

Committed by

web-flow

Commit Message

Warn when filter knobs no-op on missing columns (#25)

Audit Gap #5 from the v0.6.0–v0.7.4 review. The donor / method /
timepoint / APC / TIL filter knobs added across #15 + #9 + #20 are
all guarded with `if value > 0 and column in df.columns:` — fully
silent when the column isn't there. A user passing `--min-donors 2`
against a sheet that doesn't carry `patient_id` saw all clones pass
through with no signal that the knob was ignored.

Now emits a logger.warning naming the missing column and the relevant
sample-sheet axis, so the mismatch surfaces as terminal output.

Same pass DRYs the nine repeated knob blocks (min_donors, the four
per-method knobs, min_timepoints + per-donor variant, min_apcs + per-
donor variant, min_til_cells_per_donor) into one loop driven by a
list of (value, column, label) tuples. ~70 lines down to ~25, with
identical filtering semantics — verified by the existing knob tests
all still passing.

Tests:
  - warning fires with both knob name and column name when source
    column is absent
  - no warning when knob is at default (zero)
  - no warning when source column is present (success path)

Bumps version to 0.7.5 — additive log output, no behavior change for
correct usage; warning visibility is the only effect.

Coverage Stats

4321 of 6062 relevant lines covered (71.28%)

2.85 hits per line

Coverage Regressions

Lines	Coverage	∆	File
19	91.03	-1.19%	filter.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	python-3.10 - 25601641224.1	09 May 2026 12:55PM UTC	24	71.27	GitHub Action Run
2	python-3.9 - 25601641224.2	09 May 2026 12:55PM UTC	24	71.24	GitHub Action Run
3	python-3.12 - 25601641224.3	09 May 2026 12:55PM UTC	24	71.27	GitHub Action Run
4	python-3.11 - 25601641224.4	09 May 2026 12:55PM UTC	24	71.27	GitHub Action Run

pirl-unc / tcrsift / 25601641224
71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 25601641224

pirl-unc / tcrsift / 25601641224 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 25601641224

pirl-unc / tcrsift / 25601641224
71%

README BADGES
x