25597288768
81%

Ran 09 May 2026 09:10AM UTC

Jobs 2

Files 155

Run time 1min

Badge

Embed ▾

Committed 09 May 2026 09:07AM UTC coverage: 80.673% (+0.008%) from 80.665%

Build # 25597288768

Build Type

push

github

Committed by

web-flow

Commit Message

fix(source/crd): allow SRV targets with trailing dot in DNSEndpoint (#6383)

* source/crd: allow SRV targets with trailing dot in DNSEndpoint

The DNSEndpoint CRD validator warned and skipped SRV targets that
ended with a trailing dot, telling the user to remove it. Dropping
the dot satisfied crd.go's default branch, but then
Endpoint.ValidateSRVRecord(Targets) rejected the endpoint in
CheckEndpoint because RFC 2782 requires the target host to be an
absolute FQDN with a trailing dot. Users who tried to create an SRV
record via a DNSEndpoint CRD ended up in a loop between both errors
(issue 6357).

Treat SRV like CNAME in the crd.go validator: the SRV record format
is <prio> <weight> <port> <host> and ValidateSRVRecord already
enforces the trailing dot, so crd.go should accept it here.

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>

* test: add regression for SRV trailing-dot in DNSEndpoint CRD

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>

---------

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Co-authored-by: SAY-5 <SAY-5@users.noreply.github.com>

Coverage Stats

17226 of 21353 relevant lines covered (80.67%)

1454.23 hits per line

Coverage Regressions

Lines	Coverage	∆	File
4	89.4	0.59%	crd.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	run-macos-latest - 25597288768.1	09 May 2026 09:12AM UTC	155	80.67	GitHub Action Run
2	run-ubuntu-latest - 25597288768.2	09 May 2026 09:10AM UTC	155	80.67	GitHub Action Run

kubernetes-sigs / external-dns / 25597288768
81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 25597288768

kubernetes-sigs / external-dns / 25597288768 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 25597288768

kubernetes-sigs / external-dns / 25597288768
81%

README BADGES
x