• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubernetes-sigs / external-dns / 25597288768
81%

Build:
DEFAULT BRANCH: master
Ran 09 May 2026 09:10AM UTC
Jobs 2
Files 155
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

09 May 2026 09:07AM UTC coverage: 80.673% (+0.008%) from 80.665%
25597288768

push

github

web-flow
fix(source/crd): allow SRV targets with trailing dot in DNSEndpoint (#6383)

* source/crd: allow SRV targets with trailing dot in DNSEndpoint

The DNSEndpoint CRD validator warned and skipped SRV targets that
ended with a trailing dot, telling the user to remove it. Dropping
the dot satisfied crd.go's default branch, but then
Endpoint.ValidateSRVRecord(Targets) rejected the endpoint in
CheckEndpoint because RFC 2782 requires the target host to be an
absolute FQDN with a trailing dot. Users who tried to create an SRV
record via a DNSEndpoint CRD ended up in a loop between both errors
(issue 6357).

Treat SRV like CNAME in the crd.go validator: the SRV record format
is <prio> <weight> <port> <host> and ValidateSRVRecord already
enforces the trailing dot, so crd.go should accept it here.

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>

* test: add regression for SRV trailing-dot in DNSEndpoint CRD

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>

---------

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Co-authored-by: SAY-5 <SAY-5@users.noreply.github.com>

17226 of 21353 relevant lines covered (80.67%)

1454.23 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
89.4
0.59% crd.go
Jobs
ID Job ID Ran Files Coverage
1 run-macos-latest - 25597288768.1 09 May 2026 09:12AM UTC 155
80.67
GitHub Action Run
2 run-ubuntu-latest - 25597288768.2 09 May 2026 09:10AM UTC 155
80.67
GitHub Action Run
Source Files on build 25597288768
  • Tree
  • List 155
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #25597288768
  • e74f8d9f on github
  • Prev Build on master (#25597286539)
  • Next Build on master (#25597907215)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc