wboayue / rust-ibapi / 25593695835

92%

Build Type

push

github

Committed by web-flow

Commit Message

chore(scanner): drop text branches in scanner decoders (#532)

* chore(scanner): drop text branches in scanner decoders

`decode_scanner_data` and `decode_scanner_parameters` are now proto-only
via a `require_proto` helper that returns `Err(UnexpectedResponse)` on
text framing (skip-classifies per rule 20). Both originating gates
(`PROTOBUF_SCAN_DATA` = 210) sit at the connection floor, so the server
always emits proto framing for these messages. C# `EDecoder.cs` confirms
the dispatch is purely on the 4-byte msg-id framing — no
`if server_version >=` guards on the proto/text choice.

Inline `#[cfg(test)] mod tests` extracted to sibling `decoders_tests.rs`
per rules 13/14; added `*_rejects_text_framing` regression guards
mirroring the orders/ExecutionData precedent.

`ScannerParametersResponse` and `ScannerDataResponse` (+ `ScannerDataRow`)
builders added to `testdata/builders/scanner.rs`. Four inline raw-text
fixtures across `scanner/{sync,async}_tests.rs` swapped from
hand-rolled NUL-delimited strings → `proto_response(IncomingMessages::*,
builder.encode_proto())`.

Plan tracker updated; scanner row drops 3 text decoders + 2 dual-format
calls.

* chore(scanner): /simplify pass — lift require_proto, trim builder

- Lift `require_proto` to a `pub(crate)` method on `ResponseMessage`
  (`require_proto`). Removes the verbatim copy from
  `orders/common/decoders/mod.rs` and the new copy in
  `scanner/common/decoders.rs`. Both call sites become
  `decode_*_proto(message.require_proto()?)`. Avoids a 4-5x duplication
  across the remaining text-cleanup PRs (news, contracts, accounts,
  market_data).
- Tests: use `ResponseMessage::with_server_version()` builder instead of
  field mutation in `scanner/common/decoders_tests.rs`.
- Builder: drop `ScannerDataRow::new()` (only `pub fn new` across
  testdata builders — outlier) and the unused `security_type()` setter.
  The free function `scanner_data_row(...)` remains the single entry
  point and inlines the `Self ... (continued)

Coverage Stats

88 of 100 new or added lines in 6 files covered. (88.0%)

1 existing line in 1 file now uncovered.

18089 of 20478 relevant lines covered (88.33%)

30.47 hits per line