ben-manes / caffeine / #5443

100%

master: 100%

push

github

Wrap loader-thrown unchecked exceptions in CaffeinatedGuava

`getUnchecked` and `getAll` lumped `NullPointerException` into the same catch
arm as `InvalidCacheLoadException` and rethrew unwrapped, so a loader-thrown
NPE leaked raw to the caller instead of being wrapped in
`UncheckedExecutionException` per Guava's contract. Hoist `requireNonNull` for
argument validation and drop NPE from the rethrow arm so loader-thrown NPEs
fall into the wrapping branch.

`apply(K)` did a raw `cache.get(key)` with no exception translation, so
checked-exception loaders surfaced the package-private `CacheLoaderException`
to callers. Delegate to `getUnchecked(K)` to match Guava's
`LocalLoadingCache.apply`.

Cross-verified against pure Guava, the wrapper with a Guava loader, and the
wrapper with `caffeinate(loader)` via parameterized tests.

Surfaced by the temporal-walk audit (iss_1ef2ef59, iss_d8502f7c)

3982 of 3990 branches covered (99.8%)

5 of 5 new or added lines in 1 file covered. (100.0%)

8165 of 8165 relevant lines covered (100.0%)

1.0 hits per line